[krbdev.mit.edu #8938] git commit

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[krbdev.mit.edu #8938] git commit

Greg Hudson via RT-3

<URL: https://krbdev.mit.edu/rt/Ticket/Display.html?id=8938 >

Fix Leash crash when ticket autorenewal fails

CLeashView::RenewTicket() falls back to an ImportTicket or InitTicket
operation if ticket renewal fails.  A 2004 commit (from the old
pismere repository) added code to heuristically determine whether
Leash's cache was imported by comparing the MSLSA cache principal name
to ticketinfo.Krb5.principal.  Commit
9bc411e72fce5bed3ed00ae5b09f8c239309bae0 broke this code by removing
the call to initialize ticketinfo.Krb5 and by making
ticketinfo.Krb5.principal ephemeral.  The strcmp() call now crashes
the process with a null dereference.

Fix the crash by removing the heuristic detection of imported tickets,
using the current value of m_importedTickets (which should be correct
unless Leash was restarted after the tickets were obtained) to decide
whether to import or initialize tickets.

Author: Greg Hudson <[hidden email]>
Commit: 7fc4cdae79d0689afed32f9bcfeb28f410a9d79c
Branch: master
 src/windows/leash/LeashView.cpp |   27 ---------------------------
 1 files changed, 0 insertions(+), 27 deletions(-)

krb5-bugs mailing list
[hidden email]