[krbdev.mit.edu #8661] git commit

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[krbdev.mit.edu #8661] git commit

Jeffrey Arbuckle via RT

Move zero argc check earlier in ksu

For improved auditability, check for a zero argc value earlier in
main() so that the first two calls to com_err() can't pass a NULL
whoami value--which would be harmless, but that may not be obvious to
a reader.

https://github.com/krb5/krb5/commit/e1b5b824f5d7388a67d0854b56d3906c4fbdd778
Author: Greg Hudson <[hidden email]>
Commit: e1b5b824f5d7388a67d0854b56d3906c4fbdd778
Branch: master
 src/clients/ksu/main.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

_______________________________________________
krb5-bugs mailing list
[hidden email]
https://mailman.mit.edu/mailman/listinfo/krb5-bugs
Reply | Threaded
Open this post in threaded view
|

Re: [krbdev.mit.edu #8661] git commit

Jeffrey Arbuckle via RT
Thanks!
That makes it easier to read the code.


On Thu, Apr 26, 2018 at 5:22 PM, Greg Hudson via RT
<[hidden email]> wrote:

>
> Move zero argc check earlier in ksu
>
> For improved auditability, check for a zero argc value earlier in
> main() so that the first two calls to com_err() can't pass a NULL
> whoami value--which would be harmless, but that may not be obvious to
> a reader.
>
> https://github.com/krb5/krb5/commit/e1b5b824f5d7388a67d0854b56d3906c4fbdd778
> Author: Greg Hudson <[hidden email]>
> Commit: e1b5b824f5d7388a67d0854b56d3906c4fbdd778
> Branch: master
>  src/clients/ksu/main.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>

_______________________________________________
krb5-bugs mailing list
[hidden email]
https://mailman.mit.edu/mailman/listinfo/krb5-bugs
Reply | Threaded
Open this post in threaded view
|

Re: [krbdev.mit.edu #8661] git commit

Jeffrey Arbuckle via RT
In reply to this post by Jeffrey Arbuckle via RT
Thanks!
That makes it easier to read the code.


On Thu, Apr 26, 2018 at 5:22 PM, Greg Hudson via RT
<[hidden email]> wrote:

>
> Move zero argc check earlier in ksu
>
> For improved auditability, check for a zero argc value earlier in
> main() so that the first two calls to com_err() can't pass a NULL
> whoami value--which would be harmless, but that may not be obvious to
> a reader.
>
> https://github.com/krb5/krb5/commit/e1b5b824f5d7388a67d0854b56d3906c4fbdd778
> Author: Greg Hudson <[hidden email]>
> Commit: e1b5b824f5d7388a67d0854b56d3906c4fbdd778
> Branch: master
>  src/clients/ksu/main.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>

_______________________________________________
krb5-bugs mailing list
[hidden email]
https://mailman.mit.edu/mailman/listinfo/krb5-bugs