[SAMBA4][PATCH] Provide a hook for Samba4 into gsskrb5_init_context

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[SAMBA4][PATCH] Provide a hook for Samba4 into gsskrb5_init_context

Andrew Bartlett
This patch has a very simple purpose:  If we can't get rid of the
gssapi_krb5_context global, at least it should be one with the Samba
options set.

It is an ugly hack, and the reason I'm posting here is to get comment on
better approaches.  Is there any suggestion as to how i should specify a
gssapi_krb5_context to the appropriate routines, or a better way to
override this function?

Samba specifies options on the krb5_context for logging, and in future I
expect to add socket hooks and option sets, in addition to the
default_realm stuff already there.

Andrew Bartlett
--
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net

heimdal-gssapi-samba-hook.patch (17K) Download Attachment
signature.asc (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [SAMBA4][PATCH] Provide a hook for Samba4 into gsskrb5_init_context

Love Hörnquist Åstrand

Andrew Bartlett <[hidden email]> writes:

> This patch has a very simple purpose:  If we can't get rid of the
> gssapi_krb5_context global, at least it should be one with the Samba
> options set.

If the only option you need is to set the logging (libgssapi doesn't call
krb5_warn today, you added that ?), setting the default realm ?

I would rather see specific funtions added (gsskrb5_ ?) that did the same
thing.

Love


attachment0 (487 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [SAMBA4][PATCH] Provide a hook for Samba4 into gsskrb5_init_context

Andrew Bartlett
On Wed, 2005-09-14 at 17:48 +0200, Love Hörnquist Åstrand wrote:
> Andrew Bartlett <[hidden email]> writes:
>
> > This patch has a very simple purpose:  If we can't get rid of the
> > gssapi_krb5_context global, at least it should be one with the Samba
> > options set.
>
> If the only option you need is to set the logging (libgssapi doesn't call
> krb5_warn today, you added that ?), setting the default realm ?

Setting the default realm was one, I assumed that at some layer that
krb5_warn might be called in the krb5 libs (it would be useful, I think)
and I want to add socket, interface and DNS abstractions by means of
function pointers at some point.

> I would rather see specific funtions added (gsskrb5_ ?) that did the same
> thing.

Ok, I'll look into a gsskrb5_set_krb5_context().

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net

signature.asc (196 bytes) Download Attachment